Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor REST API to Gophercloud SDK #5137

Merged
merged 1 commit into from
Nov 23, 2023
Merged

refactor REST API to Gophercloud SDK #5137

merged 1 commit into from
Nov 23, 2023

Conversation

husnialhamdani
Copy link
Contributor

@husnialhamdani husnialhamdani commented Oct 30, 2023 •
edited
Loading

Refactor REST API to Gophercloud SDK for Openstack

Checklist

Fixes #3439

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
Copy link
Member

JorTurFer commented Oct 30, 2023 •
edited by github-actions bot
Loading

/run-e2e openstack
Update: You can check the progress here

@husnialhamdani
Copy link
Contributor Author

How to fix the pkg/scalers/openstack_swift_scaler_test.go:116:53 failures?
Is it using the same approach like this?

@JorTurFer
Copy link
Member

What do you mean?

@husnialhamdani
Copy link
Contributor Author

What do you mean?

The CI / validate is failing

@JorTurFer
Copy link
Member

JorTurFer commented Oct 30, 2023 •
edited
Loading

yeah, I saw it, but it's related with a coding error:
image

unit test need to be updated as well

This part confused me (and it was the reason for my previous question xD)

Is it using the same approach like this?

@husnialhamdani
Copy link
Contributor Author

Modified the openstack_swift_scaler_test.go, could you please check?

@husnialhamdani husnialhamdani force-pushed the rest-to-gophercloud-sdk-openstack branch 3 times, most recently from f3e4445 to b5b400b Compare November 2, 2023 15:59
@husnialhamdani husnialhamdani marked this pull request as ready for review November 5, 2023 14:35
@husnialhamdani husnialhamdani requested a review from a team as a code owner November 5, 2023 14:35
zroubalik
zroubalik reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase the PR?

CHANGELOG.md Outdated Show resolved Hide resolved
@husnialhamdani husnialhamdani force-pushed the rest-to-gophercloud-sdk-openstack branch from b5b400b to b9f4aad Compare November 21, 2023 12:54
@husnialhamdani
Copy link
Contributor Author

Could you please rebase the PR?

Rebased

zroubalik
zroubalik reviewed Nov 22, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

@husnialhamdani there's also a conflict in Changelog, could you please rebase your PR and fix the conflict?

@husnialhamdani husnialhamdani force-pushed the rest-to-gophercloud-sdk-openstack branch from 3ad1806 to 4204ba8 Compare November 22, 2023 17:48
@husnialhamdani
Copy link
Contributor Author

@husnialhamdani there's also a conflict in Changelog, could you please rebase your PR and fix the conflict?

Done

@zroubalik
Copy link
Member

zroubalik commented Nov 23, 2023 •
edited by github-actions bot
Loading

/run-e2e openstack
Update: You can check the progress here

zroubalik
zroubalik approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik enabled auto-merge (squash) November 23, 2023 09:10
@husnialhamdani
Openstack Scaler REST to Gophercloud SDK
4758e7f 
Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
auto-merge was automatically disabled November 23, 2023 10:11

Head branch was pushed to by a user without write access

@husnialhamdani husnialhamdani force-pushed the rest-to-gophercloud-sdk-openstack branch from 4204ba8 to 4758e7f Compare November 23, 2023 10:11
@zroubalik zroubalik merged commit ae04e3c into kedacore:main Nov 23, 2023
18 of 19 checks passed
@husnialhamdani
Copy link
Contributor Author

Thanks for the review and help @zroubalik @JorTurFer

yoongon pushed a commit to yoongon/keda that referenced this pull request Nov 24, 2023
@husnialhamdani @yoongon
Openstack Scaler REST to Gophercloud SDK (kedacore#5137)
29b5a57 
Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
Signed-off-by: Yoon Park <yoongon.park@gmail.com>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@husnialhamdani @toniiiik
Openstack Scaler REST to Gophercloud SDK (kedacore#5137)
7c35220 
Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use gophercloud in Openstack scalers instead of interacting with the REST Api
3 participants
@husnialhamdani @JorTurFer @zroubalik