Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling Modifiers: cast to float internally and add tests #5079

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Scaling Modifiers: cast to float internally and add tests #5079

merged 4 commits into from
Dec 15, 2023

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Oct 13, 2023 •
edited
Loading

Cast to float internally with ScalingModifiers formula to prevent wrong return value

  • wrap formula in float cast

Add more unit tests for scaling modifiers

  • webhook tests
  • internal test update

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@gauron99 gauron99 force-pushed the formula-ternary-operator-bug branch from 6a80054 to ffdd442 Compare December 15, 2023 09:08
@gauron99 gauron99 changed the title Add more scalingModifiers tests Scaling Modifiers: cast to float internally and add tests Dec 15, 2023
@gauron99 gauron99 marked this pull request as ready for review December 15, 2023 09:34
@gauron99 gauron99 requested a review from a team as a code owner December 15, 2023 09:34
@JorTurFer
Copy link
Member

JorTurFer commented Dec 15, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@gauron99 gauron99 mentioned this pull request Dec 15, 2023
Merged
zroubalik
zroubalik approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gauron99 gauron99 force-pushed the formula-ternary-operator-bug branch from d475c82 to 397fc89 Compare December 15, 2023 11:19
@zroubalik
Copy link
Member

zroubalik commented Dec 15, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) December 15, 2023 11:27
auto-merge was automatically disabled December 15, 2023 13:23

Head branch was pushed to by a user without write access

@gauron99 gauron99 force-pushed the formula-ternary-operator-bug branch from 397fc89 to ee41c99 Compare December 15, 2023 13:23
@gauron99
new test with casting to float in scalingmodifiers
cc2fe93 
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
@gauron99
cast to float internally, more SM tests
df64b9d 
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
@gauron99
fix trigger names
63f5b29 
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
@gauron99
eventing zz
7d7333a 
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
@gauron99 gauron99 force-pushed the formula-ternary-operator-bug branch from ee41c99 to 7d7333a Compare December 15, 2023 13:48
@zroubalik
Copy link
Member

zroubalik commented Dec 15, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) December 15, 2023 13:52
@zroubalik zroubalik merged commit aa5cab1 into kedacore:main Dec 15, 2023
18 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@gauron99 @toniiiik
Scaling Modifiers: cast to float internally and add tests (kedacore#5079
1a06d76 
)

Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gauron99 @JorTurFer @zroubalik