move Metrics adapter into the separate Deployment #506
+100
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zroubalik
force-pushed
the
metricSplit
branch
from
a047f8c
to
57f5322
Compare
|
Should try to get this in for 1.2 |
zroubalik
force-pushed
the
metricSplit
branch
from
57f5322
to
679e05a
Compare
|
@ahmelsayed PTAL |
|
Just to be sure, this impacts the local dev experience I presume? If so, can we update the develoepr guide please? |
ahmelsayed
approved these changes
Jan 28, 2020
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this pull request
Nov 7, 2021
…edacore#506) Signed-off-by: Benjamin <benjamin@yunify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505