Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add info about aad-pod-identity deprecation #5036

Merged
merged 4 commits into from
Oct 15, 2023
Merged

chore: add info about aad-pod-identity deprecation #5036

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c96df8
chore: add info about aad-pod-identity deprecagtion
JorTurFer Oct 1, 2023
a81e546
Update CHANGELOG.md
JorTurFer Oct 4, 2023
1694fc8
Update pkg/scaling/resolver/scale_resolvers.go
JorTurFer Oct 15, 2023
5f1d82e
Update CHANGELOG.md
JorTurFer Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ You can find all deprecations in [this overview](https://github.com/kedacore/ked

New deprecation(s):

- TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX))
- Remove support for AAD Pod Identity-based authentication ([#5035](https://github.com/kedacore/keda/issues/5035))
JorTurFer marked this conversation as resolved.
Show resolved Hide resolved

### Breaking Changes

Expand Down
4 changes: 4 additions & 0 deletions pkg/scaling/resolver/scale_resolvers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ func ResolveAuthRefAndPodIdentity(ctx context.Context, client client.Client, log
case kedav1alpha1.PodIdentityProviderAwsKiam:
authParams["awsRoleArn"] = podTemplateSpec.ObjectMeta.Annotations[kedav1alpha1.PodIdentityAnnotationKiam]
case kedav1alpha1.PodIdentityProviderAzure, kedav1alpha1.PodIdentityProviderAzureWorkload:
if podIdentity.Provider == kedav1alpha1.PodIdentityProviderAzure {
// FIXME: Delete this for v2.15
logger.Info("WARNING: aad-pod-identity is out of support (https://github.com/Azure/aad-pod-identity#-announcement) and it'll be removed from KEDA on v2.15")
JorTurFer marked this conversation as resolved.
Show resolved Hide resolved
}
if podIdentity.IdentityID != nil && *podIdentity.IdentityID == "" {
return nil, kedav1alpha1.AuthPodIdentity{Provider: kedav1alpha1.PodIdentityProviderNone}, fmt.Errorf("IdentityID of PodIdentity should not be empty")
}
Expand Down