Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pre-checks based on regex to fail the tests #4855

Closed

Conversation

sbdtu5498
Copy link

Refactored run-all.go so that regex checks can be run without running the whole test cases, thus detecting the test failure early.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4750

cc: @JorTurFer

Signed-off-by: Sanskar Bhushan <sbdtu5498@gmail.com>
@sbdtu5498 sbdtu5498 requested a review from a team as a code owner August 3, 2023 00:21
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!
One question , will this work with any amount of test cases? I afraid about any limitation on env variables :/
Can't we just move the parsing code to the utils package and call it from run-all.go and run-regex.go? Doing that, we don't need to manage env variables and checking the files twice isn't a problem because it's something super fast and light. This change also would remove the requirement of setting env variables

@sbdtu5498
Copy link
Author

Sorry for the delays @JorTurFer. I will take a look on this today and will let you know.

@JorTurFer
Copy link
Member

JorTurFer commented Sep 24, 2023

Any update? We aim to cut a release next week

@JorTurFer
Copy link
Member

Any update about this?

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbdtu5498 any update here?

@tomkerkhove
Copy link
Member

Closing due to inactivity for a long period, feel free to re-open if you have time to complete it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR e2e test: Validate the regex before building the images
4 participants