Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka Scaler: Improve error logging for GetBlock() method #4233

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Kafka Scaler: Improve error logging for GetBlock() method #4233

merged 2 commits into from
Feb 13, 2023

Conversation

dttung2905
Copy link
Contributor

Hi team,
This PR aims to make the error logging for GetBlock() more informative.

Checklist

Fixes #4232

@dttung2905
Make error logging for method more informative
856f950 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 requested a review from a team as a code owner February 13, 2023 10:22
@dttung2905
Minor typo fixing
92d5ce0 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@JorTurFer
Copy link
Member

JorTurFer commented Feb 13, 2023 •
edited by github-actions bot
Loading

/run-e2e kafka*
Update: You can check the progress here

@JorTurFer
Copy link
Member

Thanks for the contribution! ❤️

@JorTurFer JorTurFer enabled auto-merge (squash) February 13, 2023 11:01
@JorTurFer JorTurFer merged commit 72defc2 into kedacore:main Feb 13, 2023
@dttung2905 dttung2905 mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kafka Scaler: Improve error logging for GetBlock() method
2 participants
@dttung2905 @JorTurFer