Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #3782 (job duplication in azure pipelines) #3829

Closed
wants to merge 4 commits into from
Closed

Fixed issue #3782 (job duplication in azure pipelines) #3829

wants to merge 4 commits into from

Conversation

Eldarrin
Copy link
Contributor

@Eldarrin Eldarrin commented Nov 8, 2022

An active register of jobs has been created so that jobs do not get initiated more than once for a single scaler.

Checklist

  • [x ] When introducing a new scaler, I agree with the scaling governance policy
  • [x ] Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [x ] Tests have been added
  • [x ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [x ] A PR is opened to update the documentation on (repo) (if applicable)
  • [x ] Changelog has been updated and is aligned with our changelog requirements

Fixes #
#3782

Relates to #

Eldarrin and others added 4 commits October 28, 2022 17:29
@Eldarrin
Fixed issue (#3782)
b399047 
Signed-off-by: mortx <mortxbox@live.com>
@Eldarrin
Fixed duplicate agent issue (#3782)
088a2af 
Signed-off-by: mortx <mortxbox@live.com>
@Eldarrin
Tidied scaler code (#3782)
cf3c548 
Signed-off-by: mortx <mortxbox@live.com>
@Eldarrin
Delete octopus_tentacle_scaler.go
6b8b45e 
Not for this patch

Signed-off-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com>
@Eldarrin Eldarrin requested a review from a team as a code owner November 8, 2022 13:06
@Eldarrin Eldarrin marked this pull request as draft December 2, 2022 12:30
@zroubalik
Copy link
Member

@Eldarrin what is the status of this PR, please?

@Eldarrin
Copy link
Contributor Author

On hold, I don't have a solution without making the scaler stateful

@zroubalik
Copy link
Member

Okay, so I will close this PR for now.

@zroubalik zroubalik closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eldarrin @zroubalik