fix(azure blob scaler): initialize logger #3811 #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
requested changes
Nov 3, 2022
|
We also require that every commit is signed (DCO check), could you sign your commits? |
Signed-off-by: Tomas Gidén <tomas.giden@exciscope.com>
tomasgiden
force-pushed
the
fix/azure-blob-scaler-uninitialized-logger
branch
from
f53c15c
to
10dc282
Compare
JorTurFer
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger in Azure blob scaler was initialized but not saved. Thus, when logging an error, the logger segfaulted.
In addition, a very minor improvement of the log message which caused the segfault.
Note: I am not a GO developer and I have not tested it locally.
Checklist
Fixes #3811
Relates to #