chore: Add Min column to SJ visualization #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
tomkerkhove
reviewed
Sep 26, 2022
Sure, I didn't do because it's a missing part of the PR I linked (which has it's own entry) |
JorTurFer
changed the title
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
Oh sorry I missed that; it's OK |
tomkerkhove
approved these changes
Sep 26, 2022
I have created an issue and updated the changelog, is that still okey for you? |
|
/run-e2e internal* |
|
I think it's OK to explicitly call it out - It's something small with good UX impact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
Recently we added support to
minReplicaCountin ScaledJobs but we didn't update the ScaledJob definition to show this value like we do with ScaledObjectThis is how it looks after the change
Checklist
Fixes #3689
Related to #3425