fix: scaleobject ready condition 'False/Unknow' to 'True' requeue

CHANGELOG.md

@@ -49,6 +49,7 @@ To learn more about our roadmap, we recommend reading [this document](ROADMAP.md
 - **General:** Use metricName from GetMetricsSpec in ScaledJobs instead of `queueLength` ([#3032](https://github.com/kedacore/keda/issue/3032))
 - **General:** Refactor adapter startup to ensure proper log initilization. ([2316](https://github.com/kedacore/keda/issues/2316))
 - **Azure Eventhub Scaler:** KEDA operator crashes on nil memory panic if the eventhub connectionstring for Azure Eventhub Scaler contains an invalid character ([#3082](https://github.com/kedacore/keda/issues/3082))
+- **General:** Scaleobject ready condition 'False/Unknow' to 'True' requeue([#3096](https://github.com/kedacore/keda/issues/3096))
 
 ### Deprecations
 

controllers/keda/scaledobject_controller.go

@@ -123,7 +123,11 @@ func (r *ScaledObjectReconciler) SetupWithManager(mgr ctrl.Manager, options cont
 		// (in this case metadata.Generation does not change)
 		// so reconcile loop is not started on Status updates
 		For(&kedav1alpha1.ScaledObject{}, builder.WithPredicates(
-			predicate.Or(kedacontrollerutil.PausedReplicasPredicate{}, predicate.GenerationChangedPredicate{}),
+			predicate.Or(
+				kedacontrollerutil.PausedReplicasPredicate{},
+				kedacontrollerutil.ScaleObjectReadyConditionPredicate{},
+				predicate.GenerationChangedPredicate{},
+			),
 		)).
 		Owns(&autoscalingv2beta2.HorizontalPodAutoscaler{}).
 		Complete(r)

controllers/keda/util/predicate.go

@@ -3,6 +3,8 @@ package util
 import (
 	"sigs.k8s.io/controller-runtime/pkg/event"
 	"sigs.k8s.io/controller-runtime/pkg/predicate"
+
+	kedav1alpha1 "github.com/kedacore/keda/v2/apis/keda/v1alpha1"
 )
 
 const PausedReplicasAnnotation = "autoscaling.keda.sh/paused-replicas"
@@ -28,3 +30,34 @@ func (PausedReplicasPredicate) Update(e event.UpdateEvent) bool {
 	}
 	return false
 }
+
+type ScaleObjectReadyConditionPredicate struct {
+	predicate.Funcs
+}
+
+func (ScaleObjectReadyConditionPredicate) Update(e event.UpdateEvent) bool {
+	if e.ObjectOld == nil || e.ObjectNew == nil {
+		return false
+	}
+
+	var newReadyCondition, oldReadyCondition kedav1alpha1.Condition
+
+	oldObj, ok := e.ObjectOld.(*kedav1alpha1.ScaledObject)
+	if !ok {
+		return false
+	}
+	oldReadyCondition = oldObj.Status.Conditions.GetReadyCondition()
+
+	newObj, ok := e.ObjectNew.(*kedav1alpha1.ScaledObject)
+	if !ok {
+		return false
+	}
+	newReadyCondition = newObj.Status.Conditions.GetReadyCondition()
+
+	// False/Unknown -> True
+	if !oldReadyCondition.IsTrue() && newReadyCondition.IsTrue() {
+		return true
+	}
+
+	return false
+}

pkg/scaling/executor/scale_scaledobjects.go

@@ -75,7 +75,7 @@ func (e *scaleExecutor) RequestScale(ctx context.Context, scaledObject *kedav1al
 	// but ScaledObject.Status.ReadyCondition is set not set to 'true' -> set it back to 'true'
 	readyCondition := scaledObject.Status.Conditions.GetReadyCondition()
 	if !isError && !readyCondition.IsTrue() {
-		if err := e.setReadyCondition(ctx, logger, scaledObject, metav1.ConditionFalse,
+		if err := e.setReadyCondition(ctx, logger, scaledObject, metav1.ConditionTrue,
 			kedav1alpha1.ScaledObjectConditionReadySucccesReason, kedav1alpha1.ScaledObjectConditionReadySuccessMessage); err != nil {
 			logger.Error(err, "error setting ready condition")
 		}