-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added alternative expression field in AWS CloudWatch scaler #2997
Conversation
Signed-off-by: Dekel Barzilay <dekelev@gmail.com>
/run-e2e aws-cloudwatch* |
@JorTurFer Looks like it's failing on something unrelated to this PR, right? Maybe it's not working because the PR is out of sync with the main branch? It was forked about 2 weeks ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the contribution! ❤️
Only 2 things thing, could you update the changelog with the changes?
I have created an issue for tracking this,
so the line that you have to add is something like this:
- AWS CloudWatch: Add support to use expressions(#2998)
(Under the ### Improvements section)
Please, rebase also the latest changes into your branch, there are some changes needed for running e2e tests
Signed-off-by: Dekel Barzilay <dekelev@gmail.com>
Done |
/run-e2e aws-cloudwatch* |
Signed-off-by: Dekel Barzilay <dekelev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good! Great job. Just a comment on metric name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e aws-cloudwatch* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
❤️ ❤️ ❤️ ❤️
Added alternative expression field in AWS CloudWatch scaler.
Here's an example ScaledObject config:
In addition, AWS CloudWatch scaler was changed to use int64 instead of float64 for metric type, since HPA doesn't work with float numbers, integers only.
Checklist
In addition to PR #2911
Fixes #2998