Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scaler based on a GCP Stackdriver metric #2758

Merged
merged 13 commits into from
Mar 23, 2022

Conversation

RamCohen
Copy link
Contributor

feat: Add a scaler based on a GCP Stackdriver metric

Add a scaler based on a metric value obtained from GCP Stackdriver

Fixes: #2661

Signed-off-by: Ram Cohen ram.cohen@gmail.com

@RamCohen RamCohen requested a review from a team as a code owner March 14, 2022 15:56
@zroubalik
Copy link
Member

zroubalik commented Mar 16, 2022

/run-e2e gcp-stackdriver.test.ts
Update: You can check the progres here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RamCohen! Keep it coming :)

@zroubalik
Copy link
Member

@RamCohen one last nit, update Changelog please 🙏

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only small nit inline (not blocker)

pkg/scalers/gcp_stackdriver_scaler.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

It seems that you have any commit that it's not singed.
Could you solve it?

Add a scaler based on a metric value obtained from GCP Stackdriver

Fixes: 2661

Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Mar 23, 2022

/run-e2e gcp-stackdriver.test.ts
Update: You can check the progres here

@zroubalik zroubalik merged commit e3462f6 into kedacore:main Mar 23, 2022
@zroubalik
Copy link
Member

Thanks a lot @RamCohen!

@RamCohen RamCohen deleted the gcs_stackdriver branch March 23, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaler based on a GCP StackDriver metric
3 participants