Handle no metrics found for AWS Cloudwatch #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allupaku
requested review from
ahmelsayed,
JorTurFer and
zroubalik
as code owners
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or
(b) The contribution is based upon previous work that, to the
best of my knowledge, is covered under an appropriate open
source license and I have the right under that license to submit
that work with modifications, whether created in whole or in
part by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated in
the file; or
(c) The contribution was provided directly to me by some
other person who certified (a), (b) or (c) and I have not
modified it.
(d) I understand and agree that this project and the
contribution are public and that a record of the
contribution (including all personal information I
submit with it, including my sign-off) is maintained
indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Althaf Mohamed <amohamed@duosecurity.com>
|
Can you please update the changelog and see if we can add a unit test please? |
|
@allupaku we are planning to do a new release (2.5.0) in a couple of hours, I think this could go in, if you add unit test and update the Changelog |
Signed-off-by: Althaf Mohamed <amohamed@duosecurity.com>
|
Added change log and test case |
JorTurFer
approved these changes
Nov 25, 2021
JorTurFer
requested changes
Nov 25, 2021
added 2 commits
November 25, 2021 09:33
Signed-off-by: Althaf Mohamed <amohamed@duosecurity.com>
Signed-off-by: Althaf Mohamed <amohamed@duosecurity.com>
JorTurFer
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes #2302