Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Makefile #2154

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix typo in Makefile #2154

merged 1 commit into from
Oct 5, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Oct 4, 2021

Signed-off-by: jorturfer jorge_turrado@hotmail.es

After this commit, the make file fails executing make test (only if the module is not already present in the machine) because there is a typo in the Makefile. This PR fixes the typo.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@zroubalik zroubalik merged commit 9ce6287 into kedacore:main Oct 5, 2021
@JorTurFer
Copy link
Member Author

I'm a good tester for these stuffs, I don't code in GO during my daily work so I haven't already got dependencies. (That's why I detect problems in dev container for example)
xD

@JorTurFer JorTurFer deleted the fix_makefile branch October 5, 2021 09:42
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants