use Patch to set FallbackCondition on ScaledObject.Status #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
|
@mishamo FYI |
|
Hi Team.. Any update on when this PR is completed. We need to update keda in our clusters since we are still getting these errors. |
ahmelsayed
approved these changes
Aug 26, 2021
|
Sorry I missed this PR. |
Hi.. I think this change will reflect in new keda v2.5 which is scheduled to be released on 30th September. So, can you help me to understand that how can we deploy this image in production clusters now. |
|
You can use |
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
The recent Fallback feature #1910 has brought a problem in ScaledObject Status update:
the object has been modified; please apply your changes to the latest version and try again.Lets use
Patch()to mitigate this problem.Checklist
Fixes #2035