-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correcting naming and links in README #1842
Conversation
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Hi,@tomkerkhove @zroubalik PTAL. |
Hi, @tomkerkhove
This link with KedaScaleController.yaml is dead. can we skip the link and file name as it deploys keda with :
and there is no deploy folder anymore neither the kedaScaleController.yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thx
Yes please! |
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Done. PTAL @zroubalik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* correcting naming and links in readme Signed-off-by: Ritikaa96 <ritika@india.nec.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Signed-off-by: Ritikaa96 ritika@india.nec.com
There is a correction needed here.
Replacing 'scrips' with 'scripts' , Ava's link with correct ones.
Checklist