Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correcting naming and links in README #1842

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

Ritikaa96
Copy link
Contributor

@Ritikaa96 Ritikaa96 commented May 31, 2021

Signed-off-by: Ritikaa96 ritika@india.nec.com

There is a correction needed here.

See "scrips" in package.json.

Replacing 'scrips' with 'scripts' , Ava's link with correct ones.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@Ritikaa96
Copy link
Contributor Author

Ritikaa96 commented May 31, 2021

Hi,@tomkerkhove @zroubalik PTAL.

@Ritikaa96
Copy link
Contributor Author

Hi, @tomkerkhove

setup.test.ts deploys /deploy/KedaScaleController.yaml to keda namespace in the cluster, and updates the image to kedacore/keda:master

This link with KedaScaleController.yaml is dead. can we skip the link and file name as it deploys keda with :

test.serial('Deploy Keda', t => {
  let result = sh.exec('(cd .. && make deploy)')
  if (result.code !== 0) {
    t.fail('error deploying keda. ' + result)
  }
  t.pass('Keda deployed successfully using make deploy command')
})

and there is no deploy folder anymore neither the kedaScaleController.yaml.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thx

@zroubalik
Copy link
Member

Hi, @tomkerkhove

setup.test.ts deploys /deploy/KedaScaleController.yaml to keda namespace in the cluster, and updates the image to kedacore/keda:master

This link with KedaScaleController.yaml is dead. can we skip the link and file name as it deploys keda with :

test.serial('Deploy Keda', t => {
  let result = sh.exec('(cd .. && make deploy)')
  if (result.code !== 0) {
    t.fail('error deploying keda. ' + result)
  }
  t.pass('Keda deployed successfully using make deploy command')
})

and there is no deploy folder anymore neither the kedaScaleController.yaml.

Yes please!

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@Ritikaa96
Copy link
Contributor Author

Hi, @tomkerkhove

setup.test.ts deploys /deploy/KedaScaleController.yaml to keda namespace in the cluster, and updates the image to kedacore/keda:master

This link with KedaScaleController.yaml is dead. can we skip the link and file name as it deploys keda with :

test.serial('Deploy Keda', t => {
  let result = sh.exec('(cd .. && make deploy)')
  if (result.code !== 0) {
    t.fail('error deploying keda. ' + result)
  }
  t.pass('Keda deployed successfully using make deploy command')
})

and there is no deploy folder anymore neither the kedaScaleController.yaml.

Yes please!

Done. PTAL @zroubalik

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit

tests/README.md Outdated Show resolved Hide resolved
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit e882be5 into kedacore:main Jun 1, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
* correcting naming and links in readme
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants