Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak by setting logger for controller-runtime in keda-adapter #1654

Merged
merged 2 commits into from
Mar 4, 2021
Merged

fix memory leak by setting logger for controller-runtime in keda-adapter #1654

merged 2 commits into from
Mar 4, 2021

Conversation

abowloflrf
Copy link
Contributor

@abowloflrf abowloflrf commented Mar 4, 2021 •
edited by zroubalik
Loading

Set logger for controller-runtime in keda-adapter

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [N/A] Tests have been added
  • [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [N/A] A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #1639

  • memory leak of keda-adapter

image

Related issue

@abowloflrf
Set logger for controller-runtime
e4ce128 
Signed-off-by: Ruofeng Lei <ruofenglei@outlook.com>
@abowloflrf abowloflrf mentioned this pull request Mar 4, 2021
Closed
@coderanger
Copy link
Contributor

Oof, good catch. KB3 added a fix for this but we're still on 2 >_<

@abowloflrf
Copy link
Contributor Author

Oof, good catch. KB3 added a fix for this but we're still on 2 >_<

looking forward to the next release~ 😉

@abowloflrf
Update changelog and run the pre-commit hook
65eb120 
Signed-off-by: Ruofeng Lei <ruofenglei@outlook.com>
zroubalik
zroubalik approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks a lot @abowloflrf

@zroubalik zroubalik merged commit 00400f8 into kedacore:main Mar 4, 2021
@abowloflrf abowloflrf deleted the patch-1 branch March 4, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory leak of keda apiserver adapter
3 participants
@abowloflrf @coderanger @zroubalik