MSSQL Scaler: Handle zero row query results #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Gillum <cgillum@microsoft.com>
tomkerkhove
reviewed
Mar 1, 2021
|
Would it be possible to add a test for this scenario? |
|
Sorry I missed @tomkerkhove comment on the test. /cc @cgillum |
|
No problem, was thinking out Loud anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Gillum cgillum@microsoft.com
The MSSQL scaler would raise an error if a query result returned zero rows. This PR changes the behavior to instead return a metric value of
0if a query results in zero rows.Checklist
Tests have been addedN/AA PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)N/AA PR is opened to update the documentation on (repo) (if applicable)N/AChangelog has been updatedI assume this is N/A since the mssql scaler hasn't been released yet