Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local build, deployment and testing of KEDA is not a smooth experience #576

Closed
rasavant-ms opened this issue Jan 27, 2020 · 5 comments
Closed
Labels
bug Something isn't working docs:improvement-required All issues where docs should be improved help wanted Looking for support from community

Comments

@rasavant-ms
Copy link
Contributor

Expected Behavior

Documents for locally building, deploying and testing KEDA would be easy to follow and give smooth developer experience

Actual Behavior

  • Documents missing pre-requisites
    Eg. It would be nice to know the expected GOLang version, HELM version, etc.
  • Documents missing details for different operating systems.
    Eg. Command helm install . --set image.keda=kedacore/keda:$IMAGE_TAG,image.metricsAdapter=kedacore/keda-metrics-adapter:$IMAGE_TAG,image.pullPolicy=IfNotPresent does not work for Windows commandline.
  • Documents missing instructions to delete local KEDA deployment
    Eg. helm uninstall <name>

Steps to Reproduce the Problem

  1. Follow local build and deployment instructions on Github page - https://github.com/kedacore/keda#building-locally-directly
    https://github.com/kedacore/keda#deploying-custom-keda

Specifications

  • Version: N/A
  • Platform: Windows 10.0.18363 N/A Build 18363
  • Scaler(s): N/A
@rasavant-ms rasavant-ms added the bug Something isn't working label Jan 27, 2020
@jeffhollan
Copy link
Member

Thanks @rasavant-ms for raising. Tagging @melmaliacone as well only because I know they are working on some improvements to some of the local instructions and may be relevant for some of those PRs.

@jeffhollan jeffhollan added docs:improvement-required All issues where docs should be improved help wanted Looking for support from community labels Jan 28, 2020
@anirudhgarg
Copy link
Contributor

Also @rasavant-ms since you have just gone through it - would really appreciate it if you can submit any PR's to improve this.

@rasavant-ms
Copy link
Contributor Author

@melmaliacone helped me with my local deployment issues and said they are working on the PR. Would be happy to help out!

@zroubalik
Copy link
Member

This instructions should help with local development: #583

@zroubalik
Copy link
Member

I supposed this is solved already

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs:improvement-required All issues where docs should be improved help wanted Looking for support from community
Projects
None yet
Development

No branches or pull requests

4 participants