Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all needed scalers to use int64 instead of float64 #2790

Closed
6 tasks
JorTurFer opened this issue Mar 22, 2022 · 3 comments
Closed
6 tasks

Update all needed scalers to use int64 instead of float64 #2790

JorTurFer opened this issue Mar 22, 2022 · 3 comments
Assignees
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Mar 22, 2022

Proposal

The HPA doesn't allow the usage of float64 but there are some scalers where KEDA allows that, and basically KEDA cast those values into int64. This could be confusing and there is a risk of losing information like happened to this user.

We should review all the scalers and change the to use int64 values for the threshold and also internally for the returning metrics. This could be not enough because the upstream can still return float64 (missing information during the cast), so this situation should be explained also in the docs for being clearest as possible. Majority of the cases could be solved multiplying * 100 the value in the query and taking that into account for the threshold.

  • Selenium Grid Scaler (just internal represenation - ie no breaking change)
  • Metrics API Scaler
  • AWS CloudWatch Scaler
  • Huawei Cloudeye Scaler
  • InfluxDB Scaler
  • OpenStack Metrics Scaler
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Mar 22, 2022
@zroubalik zroubalik self-assigned this Mar 22, 2022
@zroubalik zroubalik reopened this Mar 25, 2022
@zroubalik
Copy link
Member

Not finished yet, we need to fix the scalers listed in the issue description -> this might be potentially user breaking, since the fields directly (in trigger spec) expects float.

@stale
Copy link

stale bot commented May 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label May 24, 2022
@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label May 24, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label May 24, 2022
@JorTurFer
Copy link
Member Author

I close this because KEDA since now, KEDA supports mili units so float64 target values make sense

@JorTurFer JorTurFer closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Archived in project
Development

No branches or pull requests

2 participants