Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keda as a generic pull-based autoscaler for K8s and Knative #19

Closed
5 tasks
bbrowning opened this issue Mar 4, 2019 · 4 comments
Closed
5 tasks

Keda as a generic pull-based autoscaler for K8s and Knative #19

bbrowning opened this issue Mar 4, 2019 · 4 comments
Labels
stale All issues that are marked as stale due to inactivity

Comments

@bbrowning
Copy link
Contributor

I'd love to see Kore become a generic pull-based autoscaler for Kubernetes and Knative. Below are the general high-level things I believe are needed to make that happen:

  • Open source Kore
  • Define an extension or plugin mechanism. If Kore supports various Azure services and Kafka out of the box, how would a user add support for another service? AMQP, other cloud provider services, etc? Where would that code live? Does it all need to live in the Kore repo? How would the person deploying Kore enable or disable specific service support?
  • Where would the Knative PodAutoscaler implementation the delegates to Kore live? Should that part live in Knative itself and just depend on Kore, which keeps Kore from needing to take a dependency on Knative? Or should it live in Kore? Or its own repo, independent of either?
  • Add unit and e2e tests so we have confidence in releases
  • Give Kore the option to watch a single namespace instead of only all namespaces. This is trivial if we move to an operator-sdk style layout, but even with what's here today it's just adding an environment variable and a bit of logic to control which namespaces we watch. I believe this is important because Kore handles Secret objects and, at least while it's fairly new, limiting its privileges to reading Secrets in a single namespace seems like a good idea.

This issue is to have a conversation about the above and track any other bits of work we need to make it happen.

@yaron2 yaron2 changed the title Kore as a generic pull-based autoscaler for K8s and Knative Keda as a generic pull-based autoscaler for K8s and Knative May 2, 2019
@jeffhollan
Copy link
Member

jeffhollan commented May 3, 2019

@bbrowning I think this is still a valid and good ask but lots has been sorted out with this since Mar 4. I think it's worth closing this and creating a separate issue to capture maybe the 5th point? Unless there are other gaps. Let me know.

@aslom
Copy link

aslom commented Nov 15, 2019

Started exploratory work on it with @zroubalik on it in knative/eventing#2153

@stale
Copy link

stale bot commented Oct 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 13, 2021
@stale
Copy link

stale bot commented Oct 20, 2021

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Oct 20, 2021
preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
joelsmith pushed a commit to joelsmith/keda that referenced this issue Mar 1, 2024
PODAUTO-86: Pull test container dockerfile, e2e targets out of CI into keda repo, reenable CPU test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

No branches or pull requests

3 participants