Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support basic authentication for Metrics API scaler #1082

Closed
tomkerkhove opened this issue Sep 4, 2020 · 5 comments
Closed

Support basic authentication for Metrics API scaler #1082

tomkerkhove opened this issue Sep 4, 2020 · 5 comments
Labels
feature All issues for new features that have been committed to good first issue Good for newcomers Hacktoberfest scaler scaler-metrics-api All issues related to our Metrics API scaler security All issues related to security

Comments

@tomkerkhove
Copy link
Member

Use-Case

Support basic authentication for Metrics API scaler

Reference

#929
@tomkerkhove tomkerkhove added needs-discussion scaler feature-request All issues for new features that have not been committed to security All issues related to security feature All issues for new features that have been committed to scaler-metrics-api All issues related to our Metrics API scaler good first issue Good for newcomers Hacktoberfest and removed feature-request All issues for new features that have not been committed to needs-discussion labels Sep 4, 2020
@aman-bansal
Copy link
Contributor

Hi @tomkerkhove, I would like to pick this issue. Based on this thread, I believe no one is doing any development on this. Just wanted to check if I can start.

@tomkerkhove
Copy link
Member Author

Nope, that is correct. Thanks for picking this up!

@aman-bansal
Copy link
Contributor

Great! I'm starting with this. Thanks!

@aman-bansal aman-bansal mentioned this issue Sep 10, 2020
Merged
4 tasks
@tomkerkhove tomkerkhove mentioned this issue Sep 15, 2020
Merged
@aman-bansal
Copy link
Contributor

@tomkerkhove this is done. can we please close this issue.

@tomkerkhove
Copy link
Member Author

Thanks!

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
@shayki5 @JorTurFer
add jobsToFetch parameter to azure pipelines docs (kedacore#1082)
14b8677 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature All issues for new features that have been committed to good first issue Good for newcomers Hacktoberfest scaler scaler-metrics-api All issues related to our Metrics API scaler security All issues related to security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomkerkhove @aman-bansal