Skip to content

Commit

Permalink
Making error messages lowercase
Browse files Browse the repository at this point in the history
Signed-off-by: Philipp Böschen <catouc@philipp.boeschen.me>
  • Loading branch information
catouc committed May 17, 2022
1 parent b970cca commit e2b30db
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions controllers/keda/scaledjob_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (r *ScaledJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
if !scaledJob.Status.Conditions.AreInitialized() {
conditions := kedav1alpha1.GetInitializedConditions()
if err := util.SetStatusConditions(ctx, r.Client, scaledJob, conditions); err != nil {
reqLogger.Error(err, "Failed to patch Objects Status with Conditions")
reqLogger.Error(err, "failed to patch Objects Status with Conditions")
return ctrl.Result{}, err
}
}
Expand Down Expand Up @@ -131,7 +131,7 @@ func (r *ScaledJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
}

if err := util.SetStatusConditions(ctx, r.Client, scaledJob, &conditions); err != nil {
reqLogger.Error(err, "Failed to patch Objects Status with Conditions")
reqLogger.Error(err, "failed to patch Objects Status with Conditions")
return ctrl.Result{}, err
}
return ctrl.Result{}, err
Expand Down
4 changes: 2 additions & 2 deletions controllers/keda/scaledobject_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func (r *ScaledObjectReconciler) Reconcile(ctx context.Context, req ctrl.Request
if !scaledObject.Status.Conditions.AreInitialized() {
conditions := kedav1alpha1.GetInitializedConditions()
if err := kedautil.SetStatusConditions(ctx, r.Client, scaledObject, conditions); err != nil {
reqLogger.Error(err, "Failed to patch Objects Status with Conditions")
reqLogger.Error(err, "failed to patch Objects Status with Conditions")
return ctrl.Result{}, err
}
}
Expand All @@ -197,7 +197,7 @@ func (r *ScaledObjectReconciler) Reconcile(ctx context.Context, req ctrl.Request
}

if err := kedautil.SetStatusConditions(ctx, r.Client, scaledObject, &conditions); err != nil {
reqLogger.Error(err, "Failed to patch Objects Status with Conditions")
reqLogger.Error(err, "failed to patch Objects Status with Conditions")
return ctrl.Result{}, err
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/scaling/executor/scale_jobs.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,12 @@ func (e *scaleExecutor) RequestJobScale(ctx context.Context, scaledJob *kedav1al
if condition.IsUnknown() || condition.IsTrue() != isActive {
if isActive {
if err := e.setActiveCondition(ctx, scaledJob, metav1.ConditionTrue, "ScalerActive", "Scaling is performed because triggers are active"); err != nil {
logger.Error(err, "Error setting active condition when triggers are active")
logger.Error(err, "error setting active condition when triggers are active")
return
}
} else {
if err := e.setActiveCondition(ctx, scaledJob, metav1.ConditionFalse, "ScalerNotActive", "Scaling is not performed because triggers are not active"); err != nil {
logger.Error(err, "Error setting active condition when triggers are not active")
logger.Error(err, "error setting active condition when triggers are not active")
return
}
}
Expand Down
10 changes: 5 additions & 5 deletions pkg/scaling/executor/scale_scaledobjects.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,12 +218,12 @@ func (e *scaleExecutor) RequestScale(ctx context.Context, scaledObject *kedav1al
if condition.IsUnknown() || condition.IsTrue() != isActive {
if isActive {
if err := e.setActiveCondition(ctx, scaledObject, metav1.ConditionTrue, "ScalerActive", "Scaling is performed because triggers are active"); err != nil {
logger.Error(err, "Error setting active condition when triggers are active")
logger.Error(err, "error setting active condition when triggers are active")
return
}
} else {
if err := e.setActiveCondition(ctx, scaledObject, metav1.ConditionFalse, "ScalerNotActive", "Scaling is not performed because triggers are not active"); err != nil {
logger.Error(err, "Error setting active condition when triggers are not active")
logger.Error(err, "error setting active condition when triggers are not active")
return
}
}
Expand All @@ -238,7 +238,7 @@ func (e *scaleExecutor) doFallbackScaling(ctx context.Context, scaledObject *ked
"New Replicas Count", scaledObject.Spec.Fallback.Replicas)
}
if e := e.setFallbackCondition(ctx, scaledObject, metav1.ConditionTrue, "FallbackExists", "At least one trigger is falling back on this scaled object"); e != nil {
logger.Error(e, "Error setting fallback condition")
logger.Error(e, "error setting fallback condition")
}
}

Expand Down Expand Up @@ -274,7 +274,7 @@ func (e *scaleExecutor) scaleToZeroOrIdle(ctx context.Context, logger logr.Logge
e.recorder.Eventf(scaledObject, corev1.EventTypeNormal, eventreason.KEDAScaleTargetDeactivated,
"Deactivated %s %s/%s from %d to %d", scaledObject.Status.ScaleTargetKind, scaledObject.Namespace, scaledObject.Spec.ScaleTargetRef.Name, currentReplicas, scaleToReplicas)
if err := e.setActiveCondition(ctx, scaledObject, metav1.ConditionFalse, "ScalerNotActive", "Scaling is not performed because triggers are not active"); err != nil {
logger.Error(err, "Error in setting active condition")
logger.Error(err, "error in setting active condition")
return
}
} else {
Expand All @@ -289,7 +289,7 @@ func (e *scaleExecutor) scaleToZeroOrIdle(ctx context.Context, logger logr.Logge
activeCondition := scaledObject.Status.Conditions.GetActiveCondition()
if !activeCondition.IsFalse() || activeCondition.Reason != "ScalerCooldown" {
if err := e.setActiveCondition(ctx, scaledObject, metav1.ConditionFalse, "ScalerCooldown", "Scaler cooling down because triggers are not active"); err != nil {
logger.Error(err, "Error in setting active condition")
logger.Error(err, "error in setting active condition")
return
}
}
Expand Down

0 comments on commit e2b30db

Please sign in to comment.