HPA: label can have max 63 chars

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
kedacore · Mar 31, 2020 · c402a0c · c402a0c
1 parent 57a7dfb
commit c402a0c
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/pkg/controller/scaledobject/scaledobject_controller.go b/pkg/controller/scaledobject/scaledobject_controller.go
@@ -353,8 +353,16 @@ func (r *ReconcileScaledObject) scaledObjectGenerationChanged(logger logr.Logger
 func (r *ReconcileScaledObject) newHPAForScaledObject(logger logr.Logger, scaledObject *kedav1alpha1.ScaledObject) (*autoscalingv2beta1.HorizontalPodAutoscaler, error) {
 	deploymentName := scaledObject.Spec.ScaleTargetRef.DeploymentName
 	scaledObjectMetricSpecs, err := r.getScaledObjectMetricSpecs(logger, scaledObject, deploymentName)
+
+	// label can have max 63 chars
+	labelName := ""
+	if len(getHpaName(deploymentName)) > 63 {
+		labelName = getHpaName(deploymentName)[:63]
+	} else {
+		labelName = getHpaName(deploymentName)
+	}
 	labels := map[string]string{
-		"app.kubernetes.io/name":       getHpaName(deploymentName),
+		"app.kubernetes.io/name":       labelName,
 		"app.kubernetes.io/version":    version.Version,
 		"app.kubernetes.io/part-of":    scaledObject.GetName(),
 		"app.kubernetes.io/managed-by": "keda-operator",