fixing transport client

Signed-off-by: aman-bansal <bansalaman2905@gmail.com>

pkg/scalers/metrics_api_scaler.go

@@ -75,21 +75,26 @@ func NewMetricsAPIScaler(resolvedEnv, metadata, authParams map[string]string) (S
 		return nil, fmt.Errorf("error parsing metric API metadata: %s", err)
 	}
 
-	var transport *http.Transport
 	if meta.enableTLS {
 		config, err := kedautil.NewTLSConfig(meta.cert, meta.key, meta.ca)
 		if err != nil {
 			return nil, err
 		}
 
-		transport = &http.Transport{TLSClientConfig: config}
+		transport := &http.Transport{TLSClientConfig: config}
+		return &metricsAPIScaler{
+			metadata: meta,
+			client: &http.Client{
+				Timeout:   3 * time.Second,
+				Transport: transport,
+			},
+		}, nil
 	}
 
 	return &metricsAPIScaler{
 		metadata: meta,
 		client: &http.Client{
-			Timeout:   3 * time.Second,
-			Transport: transport,
+			Timeout: 3 * time.Second,
 		},
 	}, nil
 }
@@ -305,6 +310,11 @@ func getMetricAPIServerRequest(meta *metricsAPIScalerMetadata) (*http.Request, e
 		}
 
 		req.SetBasicAuth(meta.username, meta.password)
+	} else {
+		req, err = http.NewRequest("GET", meta.url, nil)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	return req, nil