Skip to content

Commit

Permalink
fixing scalers after resolve conflicts
Browse files Browse the repository at this point in the history
Signed-off-by: aman-bansal <bansalaman2905@gmail.com>

Signed-off-by: aman-bansal <bansalaman2905@gmail.com>
  • Loading branch information
aman-bansal committed Oct 8, 2020
1 parent 8975a5c commit 06d18f1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions pkg/scalers/kafka_scaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"errors"
"fmt"
"github.com/kedacore/keda/pkg/util"
"strconv"
"strings"

Expand Down Expand Up @@ -219,7 +218,7 @@ func getKafkaClients(metadata kafkaMetadata) (sarama.Client, sarama.ClusterAdmin

if metadata.enableTLS {
config.Net.TLS.Enable = true
tlsConfig, err := util.NewTLSConfig(metadata.cert, metadata.key, metadata.ca)
tlsConfig, err := kedautil.NewTLSConfig(metadata.cert, metadata.key, metadata.ca)
if err != nil {
return nil, nil, err
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/scalers/metrics_api_scaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ var httpLog = logf.Log.WithName("metrics_api_scaler")

// NewMetricsAPIScaler creates a new HTTP scaler
func NewMetricsAPIScaler(resolvedEnv, metadata, authParams map[string]string) (Scaler, error) {
meta, err := metricsAPIMetadata(metadata)
meta, err := metricsAPIMetadata(metadata, authParams)
if err != nil {
return nil, fmt.Errorf("error parsing metric API metadata: %s", err)
}
Expand All @@ -90,7 +90,7 @@ func NewMetricsAPIScaler(resolvedEnv, metadata, authParams map[string]string) (S
}, nil
}

func metricsAPIMetadata(metadata map[string]string) (*metricsAPIScalerMetadata, error) {
func metricsAPIMetadata(metadata map[string]string, authParams map[string]string) (*metricsAPIScalerMetadata, error) {
meta := metricsAPIScalerMetadata{}

if val, ok := metadata["targetValue"]; ok {
Expand Down

0 comments on commit 06d18f1

Please sign in to comment.