Have relprep.sh check to see if bundle & manifest CSVs are in sync #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
generated bundle CSV's fields so that the new check passes
Checklist
Notes for reviewers:
While doing the upstream 2.12.1 release, I noticed a little weirdness in the KEDA OLM operator's
hack/relprep.sh
script. Namely, that it isn't keepingconfig/manifests/bases/keda.clusterserviceversion.yaml
andbundle/manifests/keda.clusterserviceversion.yaml
in sync. Apparently, the former doesn't get updated by theoperator-sdk generate kustomize manifests -q
command like I thought it did, and the latter does get updated, but is only used for our manual testing workflow (when we're developing or doing a release). While playing around with it, I also did some test runs on 2.13.0 and noticed that there is a new CRD coming our way which lives ineventing.keda.sh
instead ofkeda.sh
, so that also broke the script. So I've opened a PR to "fix" all of that. I'm using quotes because some of the things aren't actually fixed by the script, only detected, so that a human knows which things to manually update. I didn't figure it was worth the work to automate them at this point, but we can always change our mind later if I'm wrong.