Use installed namespace if WATCH_NAMESPACE not set #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #192 there was an attempt to change the CSV to change the installMode from
OwnNamepsace
toAllNamespaces
, but that change was lost during the next bundle re-generation. This PR re-makes that change in both the config and the bundle, but allows the operator to be installed in either mode. This provides flexibility allowing the operator to be installed into existing namespaces, potentially with other operators present, where theOperatorGroup
is already present and annotated to require one or the other.With the installMode
AllNamespaces
,WATCH_NAMESPACE
may not be set especially in cases where the operator is installed to an existing namespace with an existingoperatorgroup
. This change allows the KEDA OLM operator to work whether it is run with aWATCH_NAMESPACE
env var or not.
Checklist