Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KEDA-specific annotation name for last config, part 2 #202

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Use KEDA-specific annotation name for last config, part 2 #202

merged 1 commit into from
Aug 22, 2023

Conversation

joelsmith
Copy link
Contributor

This is a follow-up PR to #201 which was incomplete

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@joelsmith
Use KEDA-specific annotation name for last config, part 2
d8bcf99 
Signed-off-by: Joel Smith <joelsmith@redhat.com>
@joelsmith joelsmith requested a review from zroubalik as a code owner August 22, 2023 15:32
jkyros
jkyros approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jkyros jkyros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, makes sense. with the two references that got updated before, that looks like all of them
/lgtm

@joelsmith joelsmith mentioned this pull request Aug 22, 2023
Merged
1 task
@joelsmith joelsmith merged commit 1f48720 into kedacore:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkyros jkyros jkyros approved these changes

@zroubalik zroubalik Awaiting requested review from zroubalik zroubalik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelsmith @jkyros