Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify high availability descriptions #940

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

zqzten
Copy link
Contributor

@zqzten zqzten commented Sep 17, 2022

Signed-off-by: Zach Zhu zzqshu@126.com

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #861

@zqzten zqzten requested a review from a team as a code owner September 17, 2022 06:17
@netlify
Copy link

netlify bot commented Sep 17, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit f786451
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/63319d67257b010008ed02f9
😎 Deploy Preview https://deploy-preview-940--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
WDYT @kedacore/keda-docs ?

@tomkerkhove
Copy link
Member

@JorTurFer @kedacore/keda-maintainers I would bring back the "Supported Replicas" column as this is what KEDA supports, if you deviate this has implications around help

@JorTurFer JorTurFer requested a review from a team September 20, 2022 06:34
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

content/docs/2.0/operate/cluster.md Outdated Show resolved Hide resolved
Signed-off-by: Zach Zhu <zzqshu@126.com>
@tomkerkhove
Copy link
Member

Thanks!

@tomkerkhove tomkerkhove merged commit 5aa2572 into kedacore:main Sep 26, 2022
@zqzten zqzten deleted the ha-description branch September 26, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing (wrong) description on supported replica of metrics server deployment
4 participants