Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Provide Azure Application Insights scaler #638

Merged
merged 8 commits into from
Jan 31, 2022

Conversation

markrzasa
Copy link
Contributor

Signed-off-by: Mark Rzasa mark.rzasa@gmail.com

This is the documentation for an Azure Application Insights scaler. This is related to this issue:

kedacore/keda#1965

This pull request is marked as a draft because an app insights scaler may not be necessary to resolve issue 1965. Alternatively, the Azure Log Analytics scaler could be used to read app insights metrics from the AppMetrics table.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1965

@netlify
Copy link

netlify bot commented Jan 23, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 02a5663

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/61f74494c3bf7e0007e93cd1

😎 Browse the preview: https://deploy-preview-638--keda.netlify.app/docs/2.6/scalers/azure-app-insights

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first skim, thanks a ton!

content/docs/2.6/scalers/azure-app-insights.md Outdated Show resolved Hide resolved
content/docs/2.6/scalers/azure-app-insights.md Outdated Show resolved Hide resolved
content/docs/2.6/scalers/azure-app-insights.md Outdated Show resolved Hide resolved
@markrzasa
Copy link
Contributor Author

Did a first skim, thanks a ton!

No problem at all! Thanks for the comments.

@tomkerkhove
Copy link
Member

Super excited about this one, scale based on custom metrics 💘

@markrzasa
Copy link
Contributor Author

I think I've covered all of the comments. Please let me know if anything else needs to be changed. Thanks.

@tomkerkhove tomkerkhove changed the title doc for app insights scaler docs: Provide Azure Application Insights scaler Jan 26, 2022
@tomkerkhove tomkerkhove marked this pull request as ready for review January 28, 2022 13:26
markrzasa and others added 6 commits January 28, 2022 15:03
Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
…emove metricNamespace field. match doc convention

Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
…te about pod identity to app insights doc

Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
…DIRECTORY_ID

Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
@tomkerkhove tomkerkhove merged commit 80d6dbf into kedacore:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants