Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docs for azure blob #58

Merged
merged 8 commits into from
Dec 18, 2019
Merged

Conversation

IsharaPannila
Copy link
Contributor

@IsharaPannila IsharaPannila commented Dec 12, 2019

Relates to kedacore/keda#154

@msftclas
Copy link

msftclas commented Dec 12, 2019

CLA assistant check
All CLA requirements met.

content/scalers/azure-storage-blob.md Show resolved Hide resolved
content/scalers/azure-storage-blob.md Outdated Show resolved Hide resolved
content/scalers/azure-storage-blob.md Outdated Show resolved Hide resolved
content/scalers/azure-storage-blob.md Outdated Show resolved Hide resolved
content/scalers/azure-storage-blob.md Show resolved Hide resolved
content/scalers/azure-storage-blob.md Outdated Show resolved Hide resolved
content/scalers/azure-storage-blob.md Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

Thanks for the PR @IsharaPannila! I've added a few comments to improve it from a reading/explanatory perspective.

Would you mind having a look?

IsharaPannila and others added 6 commits December 13, 2019 20:56
Co-Authored-By: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-Authored-By: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-Authored-By: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-Authored-By: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-Authored-By: Tom Kerkhove <kerkhove.tom@gmail.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor change request

content/scalers/azure-storage-blob.md Outdated Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - THank you!

@tomkerkhove tomkerkhove merged commit 2e2ea7c into kedacore:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants