update aws cloudwatch scaler doc #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivesheep
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
JorTurFer
requested changes
Nov 3, 2021
Signed-off-by: Xiayang Wu <xwu@rippling.com>
fivesheep
force-pushed
the
update-cloudwatch-scaler-doc
branch
from
fb19d39
to
48fa5e5
Compare
tomkerkhove
suggested changes
Nov 4, 2021
5 tasks
Signed-off-by: Xiayang Wu <xwu@rippling.com>
tomkerkhove
approved these changes
Nov 4, 2021
|
Thank you! Waiting for the feature to merge so we can close this. |
zroubalik
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xiayang Wu xwu@rippling.com
Provide a description of what has been changed
Checklist
Fixes #
update
content/docs/2.4/scalers/aws-cloudwatch.mdandcontent/docs/2.5/scalers/aws-cloudwatch.mdfor the two new parametersmetricUnitandmetricEndTimeOffsetthat are introduced by kedacore/keda#2243