add support for all redis scaler list types #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyamor
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
tomkerkhove
reviewed
Aug 18, 2020
| @@ -9,7 +9,7 @@ go_file = "redis_scaler" | |||
|
|
|||
| ### Trigger Specification | |||
There was a problem hiding this comment.
Can you update the scaler title and description please?
| @@ -9,7 +9,7 @@ go_file = "redis_scaler" | |||
|
|
|||
| ### Trigger Specification | |||
|
|
|||
| This specification describes the `redis` trigger that scales based on the length of a list in Redis. | |||
| This specification describes the `redis` trigger that scales based on the length of a list,hash,set or sorted-set in Redis. | |||
There was a problem hiding this comment.
Can you please make it a bit more readible please?
Suggested change
| This specification describes the `redis` trigger that scales based on the length of a list,hash,set or sorted-set in Redis. | |
| This specification describes the `redis` trigger that scales based on the length of a list, hash, set or sorted-set in Redis. |
4 tasks
zroubalik
requested changes
Aug 20, 2020
|
@ilyamor do you think you can update this PR? Thanks! |
4 tasks
|
Any update on this @ilyamor? |
1 similar comment
|
Any update on this @ilyamor? |
|
Closing due to no response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to kedacore/keda#1006