Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide 404 Not Found page #229

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Aug 18, 2020

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Closes #228

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove changed the title 🚧 Provide 404 Not Found page Provide 404 Not Found page Aug 18, 2020
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Tom!

@zroubalik
Copy link
Member

@eashi ^

@tomkerkhove tomkerkhove merged commit 8f0415a into kedacore:master Aug 18, 2020
@tomkerkhove tomkerkhove deleted the not-found branch August 18, 2020 07:58
@eashi
Copy link
Contributor

eashi commented Aug 18, 2020

😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide 404 page
3 participants