Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds GCP Secret Manager trigger authentication docs #1203

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

neelanjan00
Copy link
Contributor

A description of what has been changed

  • Adds GCP Secret Manager trigger authentication docs

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Signed-off-by: neelanjan00 <neelanjan.manna@harness.io>
@neelanjan00 neelanjan00 requested a review from a team as a code owner August 6, 2023 11:18
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 45a0546
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65a2a57cc1eb710008026d3a
😎 Deploy Preview https://deploy-preview-1203--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, just a couple of nits from my side.
Also the PR title should not be chore but feat, can you please change that?

@wozniakjan
Copy link
Member

@neelanjan00 regarding the failing jobs, I think you will need to adjust .htmltest like in e03ee09

@zroubalik zroubalik changed the title chore: Adds GCP Secret Manager trigger authentication docs feat: Adds GCP Secret Manager trigger authentication docs Jan 12, 2024
@zroubalik
Copy link
Member

zroubalik commented Jan 12, 2024

@neelanjan00 please also add this page here to the list, to fix netlify issues:

- /docs/2.12/authentication-providers/configmap/

See this PR for a reference: https://github.com/kedacore/keda-docs/pull/1289/files

@neelanjan00
Copy link
Contributor Author

Thank you for the detailed reveiw, @wozniakjan @zroubalik. PTAL.

Signed-off-by: neelanjan00 <neelanjan.manna@harness.io>
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zroubalik zroubalik merged commit 0b6ffa3 into kedacore:main Jan 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants