-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds GCP Secret Manager trigger authentication docs #1203
feat: Adds GCP Secret Manager trigger authentication docs #1203
Conversation
Signed-off-by: neelanjan00 <neelanjan.manna@harness.io>
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good, just a couple of nits from my side.
Also the PR title should not be chore
but feat
, can you please change that?
content/docs/2.12/authentication-providers/gcp-secret-manager.md
Outdated
Show resolved
Hide resolved
content/docs/2.12/authentication-providers/gcp-secret-manager.md
Outdated
Show resolved
Hide resolved
content/docs/2.12/authentication-providers/gcp-secret-manager.md
Outdated
Show resolved
Hide resolved
@neelanjan00 regarding the failing jobs, I think you will need to adjust |
content/docs/2.12/authentication-providers/gcp-secret-manager.md
Outdated
Show resolved
Hide resolved
content/docs/2.12/authentication-providers/gcp-secret-manager.md
Outdated
Show resolved
Hide resolved
@neelanjan00 please also add this page here to the list, to fix netlify issues: Line 8 in 02d6f01
See this PR for a reference: https://github.com/kedacore/keda-docs/pull/1289/files |
Signed-off-by: neelanjan00 <neelanjan.manna@harness.io>
Thank you for the detailed reveiw, @wozniakjan @zroubalik. PTAL. |
Signed-off-by: neelanjan00 <neelanjan.manna@harness.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
A description of what has been changed
Checklist