Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swapping watch broadcaster channel behavior #283

Merged
merged 21 commits into from
Oct 25, 2021
Merged

swapping watch broadcaster channel behavior #283

merged 21 commits into from
Oct 25, 2021

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Oct 4, 2021 •
edited
Loading

This patch ensures that no watch event sent to broadcasters will be dropped. It also improves handling of watchers when their channels are closed.

Checklist

Fixes #

@arschles
swapping watch broadcaster channel behavior
70818f2 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles modified the milestones: v0.3.0, v0.2.0 Oct 4, 2021
arschles and others added 13 commits October 13, 2021 11:30
@arschles
Merge branch 'main' into broadcast-wait
d96136b
@arschles
small test refactor
5c6704b 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
more comments in test
f7b37c7 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
more comments and interface implementation check for fake deployment …
a7a5107 
…cache

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding comment to closeableWatcher
6c6b98d 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
forgot the beginning of comment
ae654de 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
adding error checking to the closeableWatcher
38d457d 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
removing resultCalls from the closeable watcher
fc6c932 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
removing the closeableWatcher in favor of the fake watcher functional…
78b389f 
…ity in client-go

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles
Merge branch 'main' into broadcast-wait
3d86d91
@arschles
closeableWatcher => reopeningWatcher
1cf216a 
The core functionality needed was automatic reopening of watch channels. This commit
implements that while removing some ancillary things like specifying whether
to reopen etc...

Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles
fixing nil ptr exception
057c9fe 
Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles
clarifying comments
acea1b8 
Signed-off-by: Aaron <aaron@ecomaz.net>
@arschles arschles enabled auto-merge (squash) October 19, 2021 23:32
bketelsen
bketelsen approved these changes Oct 25, 2021
View reviewed changes
Copy link

@bketelsen bketelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arschles arschles disabled auto-merge October 25, 2021 18:33
@arschles
Copy link
Collaborator Author

Thanks @bketelsen !

I'm going to manually merge this even though the linkinator check is failing. The failure is because of kedacore/keda#2215 and will be fixed separately.

@arschles arschles merged commit 8ebbabc into kedacore:main Oct 25, 2021
@arschles arschles deleted the broadcast-wait branch October 25, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bketelsen bketelsen bketelsen approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@ajanth97 ajanth97 Awaiting requested review from ajanth97

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arschles @bketelsen