Follow-up tests for multi-tenant work #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Currently failing :) Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
I forgot that it actually does start the test server in the background Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Also protecting that map with a mutex Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
7 tasks
arschles
requested review from
ahmelsayed,
ajanth97,
tomkerkhove and
zroubalik
as code owners
|
@ajanth97 this is also ready for review. can you PTAL? |
|
Expected to conflict with #280. I'll take care of resolving conflicts as necessary |
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
…epl-cache-test-add-evt Signed-off-by: Aaron <aaron@ecomaz.net>
|
Thanks @bketelsen ! I'm going to merge this manually even though the linkinator check is failing. The failure is due to kedacore/keda#2215 and the work to fix it will be done separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for the deployment cache
addEvtfunction, and the other 2 mentioned in #245Checklist
TestRunProxyServerCountMiddlewareininterceptor/main_test.goTestRunAdminServerDeploymentsEndpointininterceptor/main.go(needs Adding config endpoints on admin servers for scaler, interceptor and operator #280)TestK8sDeploymentCacheAddEvtinpkg/k8s/deployment_cache_test.goREADME.mddocs/directoryFixes #245