Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding devcontainer files #232

Merged
merged 7 commits into from
Oct 4, 2021
Merged

adding devcontainer files #232

merged 7 commits into from
Oct 4, 2021

Conversation

arschles
Copy link
Collaborator

This PR adds the necessary configuration file and Dockerfile for VS Code development containers. This feature provides fast, easy and disposable development environments for this project, either locally using VS Code (which uses Docker containers on your local machine) or in GitHub Codespaces (which is similar, but cloud hosted).

Checklist

Fixes #231

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles arschles added this to the v0.3.0 milestone Sep 22, 2021
@tomkerkhove
Copy link
Member

Great idea!

@tomkerkhove tomkerkhove requested a review from ajanth97 as a code owner October 3, 2021 15:55
Copy link
Collaborator

@ajanth97 ajanth97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles enabled auto-merge (squash) October 4, 2021 18:23
@arschles
Copy link
Collaborator Author

arschles commented Oct 4, 2021

@tomkerkhove @ajanth97 can you take one more look? I increased the Go version in the Dockerfile to 1.17

@arschles arschles merged commit 40a5c41 into kedacore:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create config / Dockerfile for dev containers
3 participants