-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Way to modify annotations and labels for created resources #36
Comments
cc/ @khaosdoctor |
On it after #42 |
#42 is finished, on it |
I'm thinking on changing a bit the API, here's the current one: spec:
appName:
image:
port:
pollingInterval: My suggestion: spec:
app:
image:
name:
port:
labels:
annotations:
ingress:
labels:
annotations:
host:
enabled:
service:
labels:
annotations:
port:
pollingInterval:
labels: # For common labels
annotations: # For common annotations |
@khaosdoctor I'd like to keep the spec simple for now, so how about something that will add annotations to all created resources: spec:
appName:
image:
port:
pollingInterval:
annotations: # the fields in here will be put as annotations on all created resources if there's a use case for custom annotations on some resources but not others, I'm open to breaking out the resources as you suggested. WDYT? |
No objections here, should I add labels as well? |
Closing this one up because of #35 becoming the main workflow for users |
…-h8snrq Delete cluster: default/somtochi
The operator creates all the resources with default labels and specs, it'd be good to add a section to the CRD spec that allowed users to add their own labels and annotations.
A simple use case would be a user who wants to use the HTTP Application Routing add-on from AKS, it needs the annotation in the ingress resource so it can update the DNS records.
The text was updated successfully, but these errors were encountered: