Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External scaler GetMetricSpec function cannot handle "interceptor" host #272

Closed
arschles opened this issue Sep 28, 2021 · 0 comments · Fixed by #273
Closed

External scaler GetMetricSpec function cannot handle "interceptor" host #272

arschles opened this issue Sep 28, 2021 · 0 comments · Fixed by #273
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@arschles
Copy link
Collaborator

arschles commented Sep 28, 2021 •
edited
Loading

The external scaler will fail if GetMetricSpec is called with "interceptor" as the ScaledObject's host value.

Expected Behavior

It returns a response that includes a target value for the interceptor fleet

Actual Behavior

It returns an error

Steps to Reproduce the Problem

@ajanth97 has reproduced this problem, so I will let him elaborate here.

Specifications

  • KEDA Version: 2.4.0
  • KEDA HTTP Add-on Version: docker images at version sha-f8d7c0b (f8d7c0b)
@arschles arschles added the bug Something isn't working label Sep 28, 2021
ajanth97 added a commit to ajanth97/http-add-on that referenced this issue Sep 28, 2021
@ajanth97
Fixing issue kedacore#272
ef93931
@ajanth97 ajanth97 mentioned this issue Sep 28, 2021
Merged
2 tasks
ajanth97 added a commit to ajanth97/http-add-on that referenced this issue Sep 28, 2021
@ajanth97
Fixing issue kedacore#272
01e90b1 
Signed-off-by: Ajanth <ajanth1997@gmail.com>
arschles added a commit to ajanth97/http-add-on that referenced this issue Oct 1, 2021
@arschles
Merge branch 'main' into issue-kedacore#272-fix
93557f3
arschles added a commit to ajanth97/http-add-on that referenced this issue Oct 6, 2021
@arschles
Merge branch 'main' into issue-kedacore#272-fix
5a99d97
arschles added a commit to ajanth97/http-add-on that referenced this issue Oct 8, 2021
@arschles
Merge branch 'main' into issue-kedacore#272-fix
af50815
ajanth97 added a commit that referenced this issue Oct 8, 2021
@ajanth97 @arschles
Handling host value of "interceptor" in GetMetricSpec (#273)
c13c1d3 
* Fixing issue #272

Signed-off-by: Ajanth <ajanth1997@gmail.com>

* Fixing scaler test

Signed-off-by: Ajanth <ajanth1997@gmail.com>

Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
@arschles arschles added this to the v0.2.0 milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Handling host value of "interceptor" in GetMetricSpec ajanth97/http-add-on
1 participant
@arschles