Skip to content

Commit

Permalink
matching DeleteScaledObject and GetScaledObject signatures
Browse files Browse the repository at this point in the history
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
  • Loading branch information
arschles committed Feb 17, 2022
1 parent be51149 commit 243be6c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion operator/controllers/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ func removeApplicationResources(
)
if err := k8s.DeleteScaledObject(
ctx,
cl,
httpso.Namespace,
config.AppScaledObjectName(httpso),
cl,
); err != nil {
if apierrs.IsNotFound(err) {
logger.Info("App ScaledObject not found, moving on")
Expand Down
2 changes: 1 addition & 1 deletion pkg/k8s/scaledobject.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ func emptyScaledObject() (*unstructured.Unstructured, error) {
// DeleteScaledObject deletes a scaled object with the given name
func DeleteScaledObject(
ctx context.Context,
cl client.Client,
ns,
name string,
cl client.Client,
) error {
scaledObj, err := emptyScaledObject()
if err != nil {
Expand Down

0 comments on commit 243be6c

Please sign in to comment.