Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keda): Allow for podLabels override in the webhooks deployment #404

Merged

Conversation

pari-
Copy link
Contributor

@pari- pari- commented Mar 10, 2023

When feat: add support to validating webhooks #352 was merged, the documented podLabels.webhooks-override in the respective webhooks deployment has been missed. 🙂

@pari- pari- requested a review from a team as a code owner March 10, 2023 18:09
@tomkerkhove
Copy link
Member

Thank you for your contribution, @pari-! Would you mind fixing the DCO issues please?

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Patrick Ringl <patrick_@freenet.de>
@pari- pari- force-pushed the fix-podlabels-override-in-webhooks-deployment branch from 5570c7f to 2354af9 Compare March 10, 2023 18:21
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 6f4b8f5 into kedacore:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants