Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide support for Azure AD Workload Identity #263

Merged
merged 4 commits into from
Apr 26, 2022
Merged

feat: Provide support for Azure AD Workload Identity #263

merged 4 commits into from
Apr 26, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Apr 26, 2022 •
edited
Loading

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Relates to kedacore/keda#2487

@v-shenoy v-shenoy requested a review from a team as a code owner April 26, 2022 07:47
@v-shenoy
Helm support for Azure AD Workload Identity.
4e0df8b 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy mentioned this pull request Apr 26, 2022
Merged
5 tasks
tomkerkhove
tomkerkhove approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean contribution, thanks 👌 Added some doc suggestions

keda/templates/01-serviceaccount.yaml Show resolved Hide resolved
keda/README.md Outdated Show resolved Hide resolved
keda/README.md Outdated Show resolved Hide resolved
keda/README.md Outdated Show resolved Hide resolved
keda/README.md Outdated Show resolved Hide resolved
keda/values.yaml Outdated Show resolved Hide resolved
@v-shenoy
Incorporate PR reviews.
8f64ca2 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Fix missing space.
2292877 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
tomkerkhove
tomkerkhove approved these changes Apr 26, 2022
View reviewed changes
keda/templates/01-serviceaccount.yaml Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

@v-shenoy Can you update the PR description to point to the issue please?

@tomkerkhove tomkerkhove changed the title Helm support for Azure AD Workload Identity. feat: Provide support for Azure AD Workload Identity Apr 26, 2022
@v-shenoy
Fix indent.
f8f6564 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Copy link
Contributor Author

@v-shenoy Can you update the PR description to point to the issue please?

Done (for the nit) & done.

@tomkerkhove tomkerkhove merged commit 9ceb455 into kedacore:main Apr 26, 2022
@tomkerkhove
Copy link
Member

Thank you!

@v-shenoy v-shenoy deleted the azwi branch April 26, 2022 09:57
@v-shenoy v-shenoy restored the azwi branch April 26, 2022 10:19
@v-shenoy v-shenoy deleted the azwi branch April 26, 2022 10:21
@v-shenoy v-shenoy mentioned this pull request Apr 26, 2022
Merged
3 tasks
@tomkerkhove tomkerkhove mentioned this pull request Apr 26, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-shenoy @tomkerkhove