Fix: container argument for keda-operator in 12-keda-deployment.yaml

[theboyisno-1]

Fixed keda-operator container argument causing pod crashloop

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
• README is updated with new configuration values (if applicable)

Fixes #191

[tomkerkhove]

@zroubalik Can you review this one please? Given this is inline with the raw YAML that we have on https://github.com/kedacore/keda/blob/main/config/manager/manager.yaml#L32

[zroubalik]

--enable-leader-election was the previous flag, --leader-elect is the new flag we are going to use with KEDA 2.5, this change was brought be migrating to Kubebuilder v3 - kedacore/keda#2082

[tomkerkhove]

So I presume this enhancement is redundant then @zroubalik ?

[zroubalik]

@tomkerkhove yeah, from 2.5 onwards we will use --leader-elect flag.

[tomkerkhove]

Thank you for your contribution but it seems like we no longer need this.

Feel free to re-open if you feel the need.

[theboyisno-1]

@tomkerkhove Thanks for your time, but I can see that latest helm chart version is 2.4 which is expecting --leader-elect flag hence we are unable to use it. My suggestion is either 2.4 should have older docker image which would work with older flag or it should have new flag.

[tomkerkhove]

v2.4 is using --enable-leader-election as per https://github.com/kedacore/charts/blob/v2.4.0/keda/templates/12-keda-deployment.yaml#L54.

What is currently in master is just the WIP version of what v2.5 will be, we only bump the chart version when we are about to ship.