Code

Nuke 13 – Swift 6#802

Code

Open

kean wants to merge 73 commits intomainkean/Nuke:mainfrom nuke13kean/Nuke:nuke13Copy head branch name to clipboard

+1,344-2,064

Commits

Commits on Jul 28, 2024

• Add ImagePipelineActor

  kean

  committed
  cc2789f

  Copy full SHA for cc2789f

• Remove deprecated APIs from ImagePipeleine

  kean

  committed
  ed5ae0b

  Copy full SHA for ed5ae0b

• Remove AsyncImageTask

  kean

  committed
  d122647

  Copy full SHA for d122647

• Remove ImagePipeline.Configuration.callbackQueue parameter

  kean

  committed
  3ce7e92

  Copy full SHA for 3ce7e92

• Add a note about ImagePipeline.Configuration

  kean

  committed
  8422630

  Copy full SHA for 8422630

• Remove onTaskCreated tests – this situation was eliminated

  kean

  committed
  1a469cb

  Copy full SHA for 1a469cb

• Safer testLoadDataDataLoaded

  kean

  committed
  e793012

  Copy full SHA for e793012

• Add ImagePublisher back

  kean

  committed
  b72c56b

  Copy full SHA for b72c56b

• Use Atomic for ImageTaskNonisolatedState

  kean

  committed
  8c6f7f2

  Copy full SHA for 8c6f7f2

• Cleanup

  kean

  committed
  786bebc

  Copy full SHA for 786bebc

• Remove deprecated APIs

  kean

  committed
  6168ab1

  Copy full SHA for 6168ab1

Commits on Aug 3, 2024

• Update unit tests

  kean

  committed
  4b2f473

  Copy full SHA for 4b2f473

• Rename Atomic to Mutex

  kean

  committed
  287b1db

  Copy full SHA for 287b1db

• Make some of ImageTask properties nonislated

  kean

  committed
  f07a2e1

  Copy full SHA for f07a2e1

• Make ImageTask/continuation private

  kean

  committed
  5a0c759

  Copy full SHA for 5a0c759

• Make ImageTask.State explicitly Sendable

  kean

  committed
  8983d5d

  Copy full SHA for 8983d5d

Commits on Aug 17, 2024

• Rework isolation in ImageTask

  kean

  committed
  796f5c6

  Copy full SHA for 796f5c6

• Remove nonisolated ImageTask.state

  kean

  committed
  039b163

  Copy full SHA for 039b163

• Remove ImageTaskExecutionContext

  kean

  committed
  109621c

  Copy full SHA for 109621c

• Cleanup ImageTask

  kean

  committed
  00d6f18

  Copy full SHA for 00d6f18

• Revert imageTaskCreated removal

  kean

  committed
  a774d51

  Copy full SHA for a774d51

• Revert imageTaskCreated removal

  kean

  committed
  4b21e2e

  Copy full SHA for 4b21e2e

• Remove soft-deprecated APIs from ImagePipeline.Delegate

  kean

  committed
  c56dbae

  Copy full SHA for c56dbae

• Rename ImagePipelineDelegate to ImagePipeline.Delegate

  kean

  committed
  45c7fd6

  Copy full SHA for 45c7fd6

• Move Combine extensions

  kean

  committed
  a2bd2f7

  Copy full SHA for a2bd2f7

• Remove DataPublisher support

  kean

  committed
  351be3a

  Copy full SHA for 351be3a

• Update warnings

  kean

  committed
  836cf75

  Copy full SHA for 836cf75

• Update DataLoading protocol to use Swift Concurrency

  kean

  committed
  f742a0c

  Copy full SHA for f742a0c

• Update ResumableDataStore to use generic namespace ID

  kean

  committed
  f4a4b74

  Copy full SHA for f4a4b74

• Revert DataLoader to use URLRequest as parameter for now

  kean

  committed
  a43d235

  Copy full SHA for a43d235

Commits on Aug 18, 2024

• Reimplement data loading with closure

  kean

  committed
  8befa46

  Copy full SHA for 8befa46

• Update ImagePrefetcher to use Swift Concurrency (partially)

  kean

  committed
  2306a4e

  Copy full SHA for 2306a4e

• Update ImagePipeline callbacks to be main actor isolated

  kean

  committed
  83dc0eb

  Copy full SHA for 83dc0eb

• Remove UncheckedSendableBox

  kean

  committed
  b8d190d

  Copy full SHA for b8d190d

• Remove now redundant _loadData method

  kean

  committed
  d650baf

  Copy full SHA for d650baf

• Fix a concurrency warning in RateLimiter

  kean

  committed
  70b92f0

  Copy full SHA for 70b92f0

• Fix RateLimiter tests

  kean

  committed
  123586a

  Copy full SHA for 123586a

• Remove one of the loadData variant

  kean

  committed
  38dc11c

  Copy full SHA for 38dc11c

• Rename makeImageTask

  kean

  committed
  2e0e6b6

  Copy full SHA for 2e0e6b6

• Rename imageTaskUpdatePriorityCalled

  kean

  committed
  1b7547a

  Copy full SHA for 1b7547a

• Soft-deprecate closure-based APIs

  kean

  committed
  7e34b50

  Copy full SHA for 7e34b50

• Remove warning in isResumableDataEnabled

  kean

  committed
  97c3ccd

  Copy full SHA for 97c3ccd

• Remove Sendable conformance from AsyncPipelineTask

  kean

  committed
  cd82f34

  Copy full SHA for cd82f34

• Remove unused isResumableDataEnabled

  kean

  committed
  868da19

  Copy full SHA for 868da19

• Remove redundant @unchecked from ImageProcessingOptions.Border

  kean

  committed
  84400f0

  Copy full SHA for 84400f0

• Remove redundant @unchecked Sendable

  kean

  committed
  0e5273b

  Copy full SHA for 0e5273b

Commits on Oct 26, 2024

• Update ImagePrefetcher

  kean

  committed
  8ab81b7

  Copy full SHA for 8ab81b7

• Update TaskTests

  kean

  committed
  1c495bd

  Copy full SHA for 1c495bd

• Update testCancelAsyncImageTask

  kean

  committed
  6df73d2

  Copy full SHA for 6df73d2

• Simplify didComplete

  kean

  committed
  6dadf6e

  Copy full SHA for 6dadf6e

• Deprecate FetchImage.load with Publisher

  kean

  committed
  3fbd5b0

  Copy full SHA for 3fbd5b0

• Update tests

  kean

  committed
  2086dc6

  Copy full SHA for 2086dc6

Commits on Oct 27, 2024

• Fix an issue with state being writable

  kean

  committed
  bf79725

  Copy full SHA for bf79725

• Sync ImageTask on ImagePipelineActor

  kean

  committed
  bca4607

  Copy full SHA for bca4607

• Update how withLock is used

  kean

  committed
  b620989

  Copy full SHA for b620989

• ImageRequest.Container is no longer Sendable

  kean

  committed
  81e8412

  Copy full SHA for 81e8412

• Update ci.yml

  kean

  committed
  072f732

  Copy full SHA for 072f732

• Update performance tests

  kean

  committed
  9c025c6

  Copy full SHA for 9c025c6

• Bump macOS deployment target to macOS 11

  kean

  committed
  a4413f6

  Copy full SHA for a4413f6

• Increase deployment targets

  kean

  committed
  de39ec1

  Copy full SHA for de39ec1

• Remove @unchecked from ImagePipeline.Error Sendable conformance

  kean

  committed
  4878846

  Copy full SHA for 4878846

Commits on Nov 17, 2024

• Fix SwiftPM build on macOS

  kean

  committed
  2896769

  Copy full SHA for 2896769

• Add retroactive conformances in test targets

  kean

  committed
  7e684d1

  Copy full SHA for 7e684d1

• Enable Swift 6

  kean

  committed
  ef82a7d

  Copy full SHA for ef82a7d

• Update RateLimiterTests to swift-testing

  kean

  committed
  bec2101

  Copy full SHA for bec2101

• Use expect instead of require

  kean

  committed
  26487ea

  Copy full SHA for 26487ea

• Enable complete concurrency checking in unit tests

  kean

  committed
  9f7eb9c

  Copy full SHA for 9f7eb9c

• Update TaskTests

  kean

  committed
  13d363e

  Copy full SHA for 13d363e

• Update ImageRequestTests

  kean

  committed
  52771a0

  Copy full SHA for 52771a0

• Update ImageCacheTests

  kean

  committed
  4e0bca9

  Copy full SHA for 4e0bca9

• Update ImageDecoderTests

  kean

  committed
  b62cc43

  Copy full SHA for b62cc43

• Update ImageDecoderRegistryTests

  kean

  committed
  f9438e3

  Copy full SHA for f9438e3

• Update ImageEncoderTests

  kean

  committed
  056d66f

  Copy full SHA for 056d66f