Update new APIs to not use ImageRequestConvertible #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageRequestConvertiblewas originally introduced in Nuke 9.2 to reduce number of versions of theloadImage(:)method in code completion, but it's no longer an issue with the new async/await APIs.ImageRequestConvertibleis soft-deprecated in Nuke 11. The other soft-deprecated APIs, such as a closure-basedImagePipeline/loadImage(:)will continue working with it. The new APIs, such as async/awaitImagePipeline/image(for:)will work withURLandImageRequestwhich is better for discoverability and performance.If you are using
ImageRequestConvertiblein your code, consider removing it now. But it won't be officially deprecated until the next major release.