Make JSON-in-KDL more minimalistic #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LemmaEOF
approved these changes
Sep 2, 2022
tabatkins
approved these changes
Sep 2, 2022
|
Very nice, I like what's going on here a lot better. |
|
🎉🎉🎉 |
larsgw
pushed a commit
that referenced
this pull request
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the new JiK microsyntax proposed in #281. Instead of explicitly requiring
(array)and(object)tags as proposed in the OP, the heuristic described in #281 (comment) is applied to detect the correct type while allowing the tags to be used in two cases where ambiguities arise.In my comment #281 (comment) I also proposed ditching the requirement for a single top-level node, but that would limit JiK to encode only JSON arrays and objects while also making it impossible to encode a JSON stream, so I did not apply that here.
Closes #281