Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds serviceaccounts,secrets and configmaps GVRs to the default Syncer sync list #680

Merged
merged 1 commit into from
Mar 16, 2022
+3 −1
Merged

Adds serviceaccounts,secrets and configmaps GVRs to the default Syncer sync list #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/syncer/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ func getAllGVRs(discoveryClient discovery.DiscoveryInterface, resourcesToSync ..
return nil, err
}
}
gvrstrs := []string{"namespaces.v1."} // A syncer should always watch namespaces
// TODO(jmprusi): Added ServiceAccounts, Configmaps and Secrets to the default syncing, but we should figure out
// a way to avoid doing that: https://github.com/kcp-dev/kcp/issues/727
gvrstrs := []string{"namespaces.v1.", "serviceaccounts.v1.", "configmaps.v1.", "secrets.v1."} // A syncer should always watch namespaces, serviceaccounts, secrets and configmaps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this also mean they are synced by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes... But we can tune the scheduler to avoid that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttts I've pushed a WIP commit, trying to solve that issue, let me know what you think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we discussed on slack, I've dropped those changes, and let's assume for now, that we sync everything by default.

Copy link
Member Author

@jmprusi jmprusi Mar 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing the default syncing discussion into Prototype4 https://github.com/kcp-dev/kcp/issues/727

for _, r := range rs {
// v1 -> v1.
// apps/v1 -> v1.apps
Expand Down
Loading