Skip to content

Update cluster-api module to v1.8.11 #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kukacz
Copy link
Contributor

@kukacz kukacz commented Mar 19, 2025

1. Please confirm that you have read the document before PR submitted

2. Contact Information(Optional)

If it is convenient, please provide your contact information so we can reach you when processing the PR:

  • CNCF Slack: @Lukáš Kubín

@kukacz kukacz force-pushed the publish-pkg-cluster-api-v1_8_11 branch from 1465357 to c74ca19 Compare March 20, 2025 07:15
Signed-off-by: Lukáš Kubín <17200879+kukacz@users.noreply.github.com>
@kukacz kukacz force-pushed the publish-pkg-cluster-api-v1_8_11 branch from c74ca19 to 817307f Compare March 20, 2025 07:29
Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukacz kukacz marked this pull request as draft April 9, 2025 07:21
@kukacz
Copy link
Contributor Author

kukacz commented Apr 9, 2025

@liangyuanpeng I've converted this to draft to prevent merge that would lead to downgrading the actual module. Let me explain:

  • There were two PRs from me at the same time in open PR queue: This one (for module version v1.8.11) and Update cluster-api module to v1.9.6 #272 (for v1.9.6).
  • I somewhat blindly assumed that they'll merge in chronological order, generating single release package per each version published in Artifact Hub. Idea was to deliver users both version options to pick from - v1.8 and v1.9.
  • Since the newer release Update cluster-api module to v1.9.6 #272 got merged first, this change would practically downgraded the module in main branch now.

I am ok to cancel this PR, the impact is negligible. I would be grateful for any proposal how to deal better with similar usecase in the future.

@Peefy
Copy link
Contributor

Peefy commented Apr 18, 2025

You can put multiple version of the package like the k8s module: https://github.com/kcl-lang/modules/tree/main/k8s

@kukacz kukacz closed this Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants